Shape 5

General Category => Suggestions => : ninnell October 30, 2015, 07:58:57 AM



: Error reporting set to 0 ???!! What the... ????
: ninnell October 30, 2015, 07:58:57 AM
 Hi,

Why would you guys set error reporting level to 0 in the template code ??? :o

I'm sorry to say, but I find it quite silly. Do you have anything to hide??  ;D

Joomla3 comes with a  handy error reporting management and admin can set the level from the back-office. Now you hard-code the level to 0 in S5FlexMenu plugin and in the cms_core_functions.php Vertex file, this feature is broken!

I've found some posts on this forum about people complaining about warnings showing up in some of your modules and your answer has always been to disable error reporting -- which is in my opinion a poor way to handle the issue. But well, I admit it's a quick fix to help people out.

BUT, hard-coding it is an horrible option. I've wasted hours trying to understand why my Joomla won't output errors in my code.

I was a big fan of your templates but I must say I'm pretty disappointed here. Please, fix this asap!


: Re: Error reporting set to 0 ???!! What the... ????
: mikek October 30, 2015, 09:08:08 AM
Hello,

There are no php errors in our files. Having error reporting set to 0 is something that other developers do as well.

"I've found some posts on this forum about people complaining about warnings showing up in some of your modules and your answer has always been to disable error reporting -- which is in my opinion a poor way to handle the issue. But well, I admit it's a quick fix to help people out."

------These are errors regarding third party extensions, not our products. Unfortunately, there are a lot of poorly written extensions out there and some customers don't understand that the errors are with those extensions and not our products. We can't provide support on third party extensions, and most customers just want the errors gone if everything else is working properly, that's the easiest solution for a customer like this and we always tell them that it's an issue with the extension that the developer needs to correct it.

We will consider possible adding a switch for this for future versions of Vertex. Thanks for your feedback. If you need to turn it off manually it's in vertex/cms_core_functions.php


: Re: Error reporting set to 0 ???!! What the... ????
: jonahh October 30, 2015, 11:49:47 AM
Hello,

I do agree that having this hard coded in would be frustrating and time consuming in a situation like yours when you need to see what the errors are. Thanks for posting this as its making us aware of this and like Mike said we can add as a switch in Vertex.

Most of the time when we tell users to disable their warning messages its because of "Strict standards" being enabled. Strict standards can take a normal warning message and turn it into an error, when really its more a suggestion.  Like "Hey, this still works but there is a new different way of doing it" so if a user upgrades their servers php version, Joomla, etc these can be produced.  So we have forced the disable so that a live site never has errors or rather warning messages show up all of a sudden.  Here is a good article on this that explains it in more detail:

www.channeldigital.co.uk/technical-blog/q-when-is-an-error-not-an-error.html



: Re: Error reporting set to 0 ???!! What the... ????
: mikenicoll October 30, 2015, 01:38:04 PM
Hello,

I agree with the idea of a switch. As Jonah said we didn't add this to hide errors in Vertex or Templates. If you actually test them you will see we have already gone through to make sure there are no errors present. The reason we added this is because a lot of users are developing websites for the first time and have no idea what happens on the server side of things.

A lot of servers by default keep strict standards enabled by default unless you change it in the php.ini file. If we left error reporting enabled this would appear as a message in the error container at the top of their website. That users first instinct would be to post here with an error message such as:

WARNING: Strict Standards...

Then we would need to tell them to either turn off error reporting as it wouldn't typically cause any issues, or they would need to make the changes on their server which most wouldn't know how to do.

But in conclusion a switch in an Advanced Tab of some sort in Vertex would be good.

-Mike


: Re: Error reporting set to 0 ???!! What the... ????
: ninnell November 03, 2015, 08:36:46 AM
Hi,

Thanks for your replies.
Why would you add a switch in Vertex when there's already one in place in Joomla's core (Global Configuration >> Server tab) ? IMHO, it would make more sense to implement such a feature in one place.

Anyway, I'll leave it to you guys to decide how to best get rid of this ugly patch. Keep up the good work and please, forget about hard-coded parameters!  ;)


Cheers